lcbp3/specs/09-history/2025-12-11_frontend-integration-review.md

Session Summary: Frontend Integration Review & Fixes

Date: 2025-12-11 Session ID: ae7069dd-6475-48f9-8c85-21694e014975

---

Objective

Review frontend integration status and fix minor issues in Correspondences, RFAs, and Drawings modules.

Work Completed

1. Integration Review ✅

Verified that all 3 core modules are properly integrated with Backend APIs:

Module	Service	Hook	API Endpoint	Status
Correspondences	correspondence.service.ts	use-correspondence.ts	/correspondences	✅ Real API
RFAs	rfa.service.ts	use-rfa.ts	/rfas	✅ Real API
Contract Drawings	contract-drawing.service.ts	use-drawing.ts	/drawings/contract	✅ Real API
Shop Drawings	shop-drawing.service.ts	use-drawing.ts	/drawings/shop	✅ Real API

2. Minor Issues Fixed ✅

2.1 components/drawings/list.tsx

• Issue: Hardcoded projectId: 1
• Fix: Added optional projectId prop to DrawingListProps interface

interface DrawingListProps {
  type: "CONTRACT" | "SHOP";
+  projectId?: number;
}

-export function DrawingList({ type }: DrawingListProps) {
-  const { data: drawings, isLoading, isError } = useDrawings(type, { projectId: 1 });
+export function DrawingList({ type, projectId }: DrawingListProps) {
+  const { data: drawings, isLoading, isError } = useDrawings(type, { projectId: projectId ?? 1 });

2.2 hooks/use-drawing.ts

• Issue: any types in multiple places
• Fix: Added proper types

+type DrawingSearchParams = SearchContractDrawingDto | SearchShopDrawingDto;
+type CreateDrawingData = CreateContractDrawingDto | CreateShopDrawingDto;

-export function useDrawings(type: DrawingType, params: any) {
+export function useDrawings(type: DrawingType, params: DrawingSearchParams) {

-mutationFn: async (data: any) => {
+mutationFn: async (data: CreateDrawingData) => {

-onError: (error: any) => {
+onError: (error: Error & { response?: { data?: { message?: string } } }) => {

2.3 hooks/use-correspondence.ts

• Issue: any types and missing mutations
• Fix:
  • Added ApiError type for error handling
  • Imported WorkflowActionDto for proper typing
  • Added useUpdateCorrespondence() mutation
  • Added useDeleteCorrespondence() mutation
  • Replaced all any types with proper types

Files Modified

1. frontend/components/drawings/list.tsx
2. frontend/hooks/use-drawing.ts
3. frontend/hooks/use-correspondence.ts

Conclusion

All frontend business modules (Correspondences, RFAs, Drawings) are confirmed to be properly integrated with Backend APIs using TanStack Query. The security features (Idempotency-Key, JWT injection) are correctly implemented in the API client. Minor type safety issues have been resolved.