np-dms/lcbp3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(rfa): complete RFA Approval Refactor - all 9 phases (T001-T080)

Browse Source 
Phase 1-2: Setup, SQL schema, enums, queue constants, base entities
Phase 3 (US1): ReviewTeam, ReviewTeamMember, ReviewTask, TaskCreationService
Phase 4 (US2): ResponseCode, ResponseCodeRule, ImplicationsService, NotificationTriggerService
Phase 5 (US3): Delegation entity, CircularDetectionService, DelegationService/Controller/Module
Phase 6 (US4): ReminderRule, SchedulerService, EscalationService, ReminderProcessor, ReminderModule
Phase 7 (US5): DistributionMatrix, DistributionRecipient, ApprovalListenerService (Strangler),
               TransmittalCreatorService, DistributionProcessor, DistributionModule
Phase 8 (US6): MatrixManagementService, InheritanceService (global→project override)
Phase 9 (Polish): AggregateStatusService, ConsensusService, VetoOverrideService,
                  ParallelGatewayHandler, review-validators, optimistic locking in completeReview,
                  test stubs (unit/integration/e2e), jest.config.js updated for tests/ directory

Frontend: ReviewTaskInbox, ParallelProgress, VetoOverrideDialog, DelegationForm,
          DelegatedBadge, MatrixEditor, ProjectOverrideManager, DistributionStatus,
          ReminderHistory, ResponseCodeSelector, CodeImplications, CompleteReviewForm,
          ReviewTeamForm, ReviewTeamSelector, TeamMemberManager

Closes #1
This commit is contained in:
Nattanin
2026-05-12 16:17:27 +07:00
parent 3df8707b7f
commit ef20839f99
82 changed files with 7052 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/tests/e2e/rfa-workflow.e2e-spec.ts
+38
View File
@@ -0,0 +1,38 @@
// File: tests/e2e/rfa-workflow.e2e-spec.ts
// E2E test ครอบคลุม RFA Approval Refactor full workflow (T077)
// TODO: ต้องมี test database + seeded data สำหรับ E2E run จริง
/**
* E2E Workflow Coverage:
* 1. RFA submit → Review Tasks created (parallel)
* 2. All reviewers complete → Consensus evaluated
* 3. Consensus APPROVED → Distribution queued
* 4. Distribution processed → Transmittal created
* 5. Veto (Code 3) → PM override → force APPROVED
* 6. Reminder sent when task overdue
* 7. Delegation: delegate completes task on behalf
*/
describe('RFA Approval Workflow (E2E)', () => {
// TODO: Bootstrap NestJS test app + seed test data
describe('Phase 1-3: Submit → Parallel Review → Consensus', () => {
it.todo('should create parallel review tasks on RFA submit');
it.todo('should evaluate APPROVED consensus when all Code 1A');
it.todo('should evaluate REJECTED consensus when any Code 3');
it.todo('should allow PM override of Code 3 veto');
});
describe('Phase 4-5: Delegation → Reminder', () => {
it.todo('should delegate review task to another user');
it.todo('should block circular delegation');
it.todo('should send reminder when task is overdue');
it.todo('should escalate to L2 after 3 days overdue');
});
describe('Phase 6-7: Distribution', () => {
it.todo('should queue distribution after APPROVED consensus');
it.todo('should create Transmittal records from distribution matrix');
it.todo('should skip distribution for REJECTED');
});
});