feat(rfa): complete RFA Approval Refactor - all 9 phases (T001-T080)

Phase 1-2: Setup, SQL schema, enums, queue constants, base entities
Phase 3 (US1): ReviewTeam, ReviewTeamMember, ReviewTask, TaskCreationService
Phase 4 (US2): ResponseCode, ResponseCodeRule, ImplicationsService, NotificationTriggerService
Phase 5 (US3): Delegation entity, CircularDetectionService, DelegationService/Controller/Module
Phase 6 (US4): ReminderRule, SchedulerService, EscalationService, ReminderProcessor, ReminderModule
Phase 7 (US5): DistributionMatrix, DistributionRecipient, ApprovalListenerService (Strangler),
               TransmittalCreatorService, DistributionProcessor, DistributionModule
Phase 8 (US6): MatrixManagementService, InheritanceService (global→project override)
Phase 9 (Polish): AggregateStatusService, ConsensusService, VetoOverrideService,
                  ParallelGatewayHandler, review-validators, optimistic locking in completeReview,
                  test stubs (unit/integration/e2e), jest.config.js updated for tests/ directory

Frontend: ReviewTaskInbox, ParallelProgress, VetoOverrideDialog, DelegationForm,
          DelegatedBadge, MatrixEditor, ProjectOverrideManager, DistributionStatus,
          ReminderHistory, ResponseCodeSelector, CodeImplications, CompleteReviewForm,
          ReviewTeamForm, ReviewTeamSelector, TeamMemberManager

Closes #1
This commit is contained in:
Nattanin
2026-05-12 16:17:27 +07:00
parent 3df8707b7f
commit ef20839f99
82 changed files with 7052 additions and 104 deletions
@@ -0,0 +1,85 @@
// File: src/modules/workflow-engine/dsl/parallel-gateway.handler.ts
// Parallel Gateway DSL handler สำหรับ RFA parallel review (T066, ADR-001)
// Strangler Pattern: ขยาย WorkflowEngine โดยไม่แก้ไข core DSL
import { Injectable, Logger } from '@nestjs/common';
export interface ParallelGatewayStep {
type: 'parallel_gateway';
id: string;
branches: ParallelBranch[];
completionStrategy: 'ALL' | 'MAJORITY' | 'ANY';
onComplete: string; // next step ID
}
export interface ParallelBranch {
id: string;
assigneeType: 'DISCIPLINE' | 'USER' | 'TEAM';
assigneeId: string; // publicId
steps: string[]; // step IDs within this branch
}
export interface GatewayExecutionContext {
rfaRevisionPublicId: string;
completedBranches: Set<string>;
totalBranches: number;
}
@Injectable()
export class ParallelGatewayHandler {
private readonly logger = new Logger(ParallelGatewayHandler.name);
/**
* ตรวจสอบว่า gateway สามารถเดินหน้าได้หรือยัง ตาม completionStrategy (FR-008)
*/
canAdvance(step: ParallelGatewayStep, ctx: GatewayExecutionContext): boolean {
const { completedBranches, totalBranches } = ctx;
switch (step.completionStrategy) {
case 'ALL':
return completedBranches.size === totalBranches;
case 'MAJORITY':
return completedBranches.size > Math.floor(totalBranches / 2);
case 'ANY':
return completedBranches.size >= 1;
default:
this.logger.warn(`Unknown completion strategy: ${step.completionStrategy as string}`);
return false;
}
}
/**
* สร้าง execution context จาก gateway definition
*/
createContext(
rfaRevisionPublicId: string,
step: ParallelGatewayStep,
): GatewayExecutionContext {
return {
rfaRevisionPublicId,
completedBranches: new Set<string>(),
totalBranches: step.branches.length,
};
}
/**
* Mark a branch complete and check if gateway can advance
*/
markBranchComplete(
ctx: GatewayExecutionContext,
branchId: string,
step: ParallelGatewayStep,
): { canAdvance: boolean; completedCount: number } {
ctx.completedBranches.add(branchId);
const canAdvance = this.canAdvance(step, ctx);
this.logger.log(
`Branch ${branchId} complete. ${ctx.completedBranches.size}/${ctx.totalBranches} — canAdvance: ${canAdvance}`,
);
return { canAdvance, completedCount: ctx.completedBranches.size };
}
}