feat(rfa): complete RFA Approval Refactor - all 9 phases (T001-T080)

Phase 1-2: Setup, SQL schema, enums, queue constants, base entities Phase 3 (US1): ReviewTeam, ReviewTeamMember, ReviewTask, TaskCreationService Phase 4 (US2): ResponseCode, ResponseCodeRule, ImplicationsService, NotificationTriggerService Phase 5 (US3): Delegation entity, CircularDetectionService, DelegationService/Controller/Module Phase 6 (US4): ReminderRule, SchedulerService, EscalationService, ReminderProcessor, ReminderModule Phase 7 (US5): DistributionMatrix, DistributionRecipient, ApprovalListenerService (Strangler), TransmittalCreatorService, DistributionProcessor, DistributionModule Phase 8 (US6): MatrixManagementService, InheritanceService (global→project override) Phase 9 (Polish): AggregateStatusService, ConsensusService, VetoOverrideService, ParallelGatewayHandler, review-validators, optimistic locking in completeReview, test stubs (unit/integration/e2e), jest.config.js updated for tests/ directory Frontend: ReviewTaskInbox, ParallelProgress, VetoOverrideDialog, DelegationForm, DelegatedBadge, MatrixEditor, ProjectOverrideManager, DistributionStatus, ReminderHistory, ResponseCodeSelector, CodeImplications, CompleteReviewForm, ReviewTeamForm, ReviewTeamSelector, TeamMemberManager Closes #1
2026-05-12 16:17:27 +07:00
parent 3df8707b7f
commit ef20839f99
82 changed files with 7052 additions and 104 deletions
@@ -0,0 +1,112 @@
+// File: src/modules/review-team/services/task-creation.service.ts
+// Strangler Pattern: แยก logic การสร้าง Parallel Review Tasks ออกจาก rfa.service.ts
+// เรียกใช้หลังจาก RFA Submit สำเร็จ (T017 integration)
+
+import { Injectable, Logger } from '@nestjs/common';
+import { InjectRepository } from '@nestjs/typeorm';
+import { Repository, EntityManager } from 'typeorm';
+import { ReviewTeam } from '../entities/review-team.entity';
+import { ReviewTeamMember } from '../entities/review-team-member.entity';
+import { ReviewTask } from '../entities/review-task.entity';
+import { ReviewTaskStatus } from '../../common/enums/review.enums';
+
+@Injectable()
+export class TaskCreationService {
+  private readonly logger = new Logger(TaskCreationService.name);
+
+  constructor(
+    @InjectRepository(ReviewTeam)
+    private readonly reviewTeamRepo: Repository<ReviewTeam>,
+    @InjectRepository(ReviewTeamMember)
+    private readonly memberRepo: Repository<ReviewTeamMember>,
+    @InjectRepository(ReviewTask)
+    private readonly reviewTaskRepo: Repository<ReviewTask>,
+  ) {}
+
+  /**
+   * สร้าง Parallel Review Tasks สำหรับแต่ละ Discipline ใน Review Team (FR-003)
+   * เรียกใช้ภายใน Transaction ของ rfa.service.ts submit method
+   *
+   * @param rfaRevisionId - Internal ID ของ RFA Revision
+   * @param reviewTeamPublicId - publicId ของ Review Team (ADR-019)
+   * @param dueDate - กำหนดเวลาตรวจสอบ
+   * @param manager - EntityManager จาก QueryRunner (ใช้ Transaction เดิม)
+   */
+  async createParallelTasks(
+    rfaRevisionId: number,
+    reviewTeamPublicId: string,
+    dueDate: Date,
+    manager: EntityManager,
+  ): Promise<ReviewTask[]> {
+    // ดึง ReviewTeam พร้อม members
+    const team = await this.reviewTeamRepo.findOne({
+      where: { publicId: reviewTeamPublicId },
+      relations: ['members'],
+    });
+
+    if (!team || !team.isActive) {
+      this.logger.warn(
+        `ReviewTeam ${reviewTeamPublicId} not found or inactive — skipping task creation`,
+      );
+      return [];
+    }
+
+    const members = team.members ?? [];
+
+    if (members.length === 0) {
+      this.logger.warn(
+        `ReviewTeam ${reviewTeamPublicId} has no members — skipping task creation`,
+      );
+      return [];
+    }
+
+    // กลุ่ม members ตาม disciplineId (แต่ละ Discipline ต้องการเพียง 1 Task)
+    const disciplineMap = new Map<number, ReviewTeamMember>();
+    for (const member of members) {
+      // LEAD มี priority สูงสุด ถ้ามีหลายคนใน Discipline เดียวกัน
+      const existing = disciplineMap.get(member.disciplineId);
+      if (!existing || member.role === 'LEAD') {
+        disciplineMap.set(member.disciplineId, member);
+      }
+    }
+
+    const tasks: ReviewTask[] = [];
+
+    // สร้าง ReviewTask สำหรับแต่ละ Discipline พร้อมกัน (Parallel)
+    for (const [disciplineId, leadMember] of disciplineMap) {
+      const task = manager.create(ReviewTask, {
+        rfaRevisionId,
+        teamId: team.id,
+        disciplineId,
+        assignedToUserId: leadMember.userId,
+        status: ReviewTaskStatus.PENDING,
+        dueDate,
+      });
+      const saved = await manager.save(ReviewTask, task);
+      tasks.push(saved);
+    }
+
+    this.logger.log(
+      `Created ${tasks.length} parallel review tasks for RFA revision ${rfaRevisionId}, team ${reviewTeamPublicId}`,
+    );
+
+    return tasks;
+  }
+
+  /**
+   * ตรวจสอบว่า RFA Revision มี Review Tasks ครบทุก Discipline แล้วหรือยัง
+   */
+  async areAllTasksCompleted(rfaRevisionId: number): Promise<boolean> {
+    const tasks = await this.reviewTaskRepo.find({
+      where: { rfaRevisionId },
+    });
+
+    if (tasks.length === 0) return false;
+
+    return tasks.every(
+      (t: ReviewTask) =>
+        t.status === ReviewTaskStatus.COMPLETED ||
+        t.status === ReviewTaskStatus.CANCELLED,
+    );
+  }
+}