260324:0945 fix ci-deploy : optimize #02

2026-03-24 09:45:34 +07:00
parent 837bea4237
commit a60bb0ba71
3 changed files with 436 additions and 30 deletions
@@ -1,6 +1,6 @@
 # NAP-DMS Project Context & Rules
 - For: Windsurf Cascade (and compatible: Codex CLI, opencode, Amp, Amazon Q, AGENTS.md tools)
- - Version: 1.8.3 (Enforcement Tiers Added) | Last synced from repo: 2026-03-21
+ - Version: 1.8.4 (Accuracy Pass) | Last synced from repo: 2026-03-24
 - Repo: [https://git.np-dms.work/np-dms/lcbp3](https://git.np-dms.work/np-dms/lcbp3)

 ---
@@ -73,7 +73,7 @@ Best practice — ทำตามถ้าทำได้ ไม่ block:
 | AI Migration  | 🔄 Pre-migration Setup  | n8n + Ollama (ADR-017/018)                             |
 | Testing       | 🔄 UAT In Progress      | Per `01-05-acceptance-criteria.md`                     |
 | Deployment    | 📋 Pending Go-Live Gate | Blue-Green, QNAP Container Station                     |
-| ADR-019 UUID  | 🔄 Phase 5.4 Pending    | 4 frontend files still use `parseInt()` on UUID        |
+| ADR-019 UUID  | ✅ All Phases Complete   | Phase 5.4 done — all UUID FK issues resolved           |
 **Domain:** `np-dms.work`

 ---
@@ -96,7 +96,7 @@ Best practice — ทำตามถ้าทำได้ ไม่ block:
 ### Frontend

 - **Next.js 16.2.0** (App Router + `proxy.ts`) + **React 19.2.4**
- **Tailwind CSS 4.2.2** + **Shadcn/UI**
+- **Tailwind CSS 3.4.3** + **Shadcn/UI**
 - **TanStack Query** — **Server State only**
 - **Zustand** — **Client State only**
 - **React Hook Form 7.71.2** + **Zod 4.3.6** + **@hookform/resolvers 3.9.0** — **Form State only**
@@ -122,7 +122,7 @@ Best practice — ทำตามถ้าทำได้ ไม่ block:

 ### Security Overrides (pnpm overrides active in root `package.json`)

- `uuid@11.0.0`, `multer@>=2.1.1`, `undici@>=7.24.0`, `axios@>=1.13.5` — patched
+- 30+ security overrides active (`multer@>=2.1.1`, `undici@>=7.24.0`, `axios@>=1.13.5`, etc.)
 - All 52 vulnerabilities resolved as of 2026-03-19 (27 high + 20 moderate + 5 low)

 ---
@@ -160,7 +160,7 @@ specs/
 ├── 03-Data-and-Storage/  # Schema v1.8.0 (3 files), Seed Data, Data Dictionary, Migration Scope
 ├── 04-Infrastructure-OPS/# Docker, Monitoring, Deployment, Incident Response, Release Policy
 ├── 05-Engineering-Guidelines/ # Fullstack, Backend, Frontend, Testing, UUID Implementation
-├── 06-Decision-Records/  # 19 ADRs (ADR-001 to ADR-019)
+├── 06-Decision-Records/  # 16 ADRs defined (15 with file, ADR-003/004/007 not created)
 └── 99-archives/          # ประวัติ tasks เก่า
 ```

@@ -170,9 +170,11 @@ Schema is split — modify the correct file:
 - `lcbp3-v1.8.0-schema-02-tables.sql` ← **primary reference for all queries**
 - `lcbp3-v1.8.0-schema-03-views-indexes.sql`

+> **UUID Storage (MariaDB-specific):** Column type is `uuid UUID NOT NULL DEFAULT UUID()` — MariaDB native UUID, NOT MySQL's `BINARY(16)` + `UUID_TO_BIN()`/`BIN_TO_UUID()`. No transformer needed. `x.uuid` in Views directly (no conversion function).
+
 ---

-## 📐 ADR Reference (19 total)
+## 📐 ADR Reference (16 defined)

 | ADR     | Topic                      | Key Decision                                       |
 | ------- | -------------------------- | -------------------------------------------------- |
@@ -191,7 +193,7 @@ Schema is split — modify the correct file:
 | ADR-016 | Security                   | JWT + CASL RBAC + Helmet.js + ClamAV               |
 | ADR-017 | Ollama Migration           | Local AI + n8n for legacy data import (~20K docs)  |
 | ADR-018 | AI Boundary (Patch 1.8.1)  | AI isolation — no direct DB/storage access         |
-| ADR-019 | Hybrid Identifier Strategy | INT PK (internal) + UUIDv7 BINARY(16) (public API) |
+| ADR-019 | Hybrid Identifier Strategy | INT PK (internal) + UUIDv7 MariaDB native UUID (public API) |

 ---

@@ -200,17 +202,17 @@ Schema is split — modify the correct file:
 ### Rule Summary

 - **Internal / DB FK:** `INT AUTO_INCREMENT` (Primary Key) — never exposed
- **Public API / URL:** `UUIDv7` stored as `BINARY(16)`
+- **Public API / URL:** `UUIDv7` stored as MariaDB native `UUID` type (auto-stored as BINARY(16), no transformer needed)
 - Read `05-07-hybrid-uuid-implementation-plan.md` before any UUID-related work.

-### ⚠️ Phase 5.4 — Pending Fix (as of 2026-03-20)
+### ✅ Phase 5.4 — COMPLETED (2026-03-21)

-These files still call `parseInt()` on UUID values — **fix when touching these files**:
+All UUID FK issues resolved — no more `parseInt()` on UUID values:

- `frontend/components/correspondences/form.tsx`
- `frontend/components/user-dialog.tsx`
- `frontend/components/numbering/template-tester.tsx`
- `frontend/app/(dashboard)/rfas/page.tsx`
+- `frontend/components/correspondences/form.tsx` ✅ fixed
+- `frontend/components/admin/user-dialog.tsx` ✅ fixed
+- `frontend/components/numbering/template-tester.tsx` ✅ fixed
+- `frontend/app/(dashboard)/rfas/page.tsx` ✅ fixed

 ### UUID Serialization Behavior (TransformInterceptor)

@@ -488,12 +490,16 @@ adr/019-uuid-serialization-behavior

 `.windsurf/workflows/` — ใช้สำหรับ repeatable / complex tasks เช่น:

- UUID migration fixes (Phase 5.4)
+- ADR-019 UUID pattern verification
 - Spec review & gap analysis
 - Security audit checklist
 - Release gate verification
-  เมื่อ task ซับซ้อนและทำซ้ำได้ ให้ดู `.windsurf/workflows/` ก่อนเขียน code ใหม่
-  ---## 🚀 Deployment Rules (ADR-015)
+
+เมื่อ task ซับซ้อนและทำซ้ำได้ ให้ดู `.windsurf/workflows/` ก่อนเขียน code ใหม่
+
+---
+
+## 🚀 Deployment Rules (ADR-015)
 - Docker Compose on **QNAP Container Station** (production).
 - **NO `.env` files in production** — secrets in `docker-compose.yml` environment section directly.
 - Blue-Green deployment strategy.
@@ -565,7 +571,7 @@ adr/019-uuid-serialization-behavior
 | "สร้าง API ใหม่"       | `05-02-backend-guidelines.md`, `schema-02-tables.sql`   | NestJS Controller + Service + DTO + CASL Guard    |
 | "แก้ฟอร์ม frontend"    | `05-03-frontend-guidelines.md`, `01-06-edge-cases.md`   | RHF+Zod + TanStack Query + Thai comments          |
 | "เพิ่ม field ใหม่"      | `ADR-009`, `data-dictionary.md`, `schema-02-tables.sql` | แก้ SQL โดยตรง + อัพเดท Data Dictionary + Entity    |
-| "ตรวจสอบ UUID"       | `ADR-019`, `05-07-hybrid-uuid-implementation-plan.md`   | UUIDv7 BINARY(16) + TransformInterceptor behavior |
+| "ตรวจสอบ UUID"       | `ADR-019`, `05-07-hybrid-uuid-implementation-plan.md`   | UUIDv7 MariaDB native UUID + TransformInterceptor behavior |
 | "สร้าง migration"     | `ADR-009`, `03-06-migration-business-scope.md`          | แก้ SQL schema โดยตรง + n8n workflow               |
 | "ตรวจสอบ permission" | `seed-permissions.sql`, `ADR-016`                       | CASL 4-Level RBAC matrix                          |
 | "deploy production"  | `04-08-release-management-policy.md`, `ADR-015`         | Release Gates + Blue-Green strategy               |
@@ -627,15 +633,13 @@ if (!entity) {
 ### Frontend Query Pattern

 ```typescript
-// [frontend-query] → TanStack Query มาตรฐาน
+// [frontend-query] → TanStack Query v5 มาตรฐาน
 const { data, error, isLoading } = useQuery({
  queryKey: ['correspondence', uuid],
  queryFn: () => api.get(`/correspondences/${uuid}`),
-  onError: (err) => {
-    toast.error('ไม่สามารถโหลดข้อมูลได้');
-    logger.error('Failed to load correspondence', { uuid, err });
-  },
 });
+// v5: onError ถูกลบออกจาก useQuery — จัดการ error ผ่าน return value
+if (error) toast.error('ไม่สามารถโหลดข้อมูลได้');
 ```

 ### Redis Cache Pattern
@@ -672,16 +676,16 @@ return null; // ❌ ทำให้ caller ต้องเช็คเอง
 ### Frontend (Next.js)

 ```typescript
-// ✅ ถูกต้อง — ใช้ TanStack Query error handling
+// ✅ ถูกต้อง — ใช้ TanStack Query v5 error handling
 const { data, error, isLoading } = useQuery({
  queryKey: ['correspondence', uuid],
  queryFn: () => api.get(`/correspondences/${uuid}`),
-  onError: (err) => {
-    // แสดง toast + log + fallback UI
-    toast.error('ไม่สามารถโหลดข้อมูลได้');
-    logger.error('Failed to load correspondence', { uuid, err });
-  },
 });
+// v5: onError removed from useQuery — handle via error return value
+if (error) {
+  // แสดง toast + fallback UI
+  toast.error('ไม่สามารถโหลดข้อมูลได้');
+}
 ```

 ### Error Response Standard (Backend)
@@ -856,6 +860,7 @@ Request: ตรวจสอบตาม spec + ADRs + Forbidden Actions table

 | Version | Date       | Changes                                                                                                               | Updated By     |
 | ------- | ---------- | --------------------------------------------------------------------------------------------------------------------- | -------------- |
+| 1.8.4   | 2026-03-24 | Phase 5.4→✅ DONE, Tailwind 3.4.3, ADR count(16), MariaDB UUID note, TanStack v5 patterns, formatting fix               | Windsurf AI    |
 | 1.8.3   | 2026-03-21 | + Rule Enforcement Tiers (🔴🟡🟢), + Tiered Development Flow                                                             | Human Dev + AI |
 | 1.8.2   | 2026-03-21 | + Context Triggers, + Code Snippets, + Error Handling, + i18n, + Performance, + Testing Checklist, + Prompt Templates | Human Dev + AI |
 | 1.8.1   | 2026-03-21 | + ADR-019 UUID patterns, + Phase 5.4 pending files                                                                    | Claude Sonnet  |
@@ -867,7 +872,7 @@ Request: ตรวจสอบตาม spec + ADRs + Forbidden Actions table
 1. แก้ไขในส่วนที่เกี่ยวข้อง
 2. อัพเดทตาราง Change Log ด้านบน
 3. เพิ่ม version number ใน header
-4. Commit ด้วย message: `spec(windsurfrules): bump to v1.8.3 - <brief description>`
+4. Commit ด้วย message: `spec(windsurfrules): bump to v1.8.4 - <brief description>`

 ---