260322:1648 Correct Coresspondence / Doing RFA / Correct CI
This commit is contained in:
@@ -6,11 +6,13 @@
|
||||
## 🛠 Fixes & Changes
|
||||
|
||||
### 1. Revision-Based List View
|
||||
|
||||
- **Issue:** The Correspondence List was displaying one row per Document, hiding revision history.
|
||||
- **Fix:** Refactored `CorrespondenceService.findAll` to query `CorrespondenceRevision` as the primary entity.
|
||||
- **Outcome:** The list now displays every revision (e.g., Doc-001 Rev A, Doc-001 Rev B) as separate rows. Added "Rev" column to the UI.
|
||||
|
||||
### 2. Correspondence Detail Page
|
||||
|
||||
- **Issue:** Detail page was not displaying Subject/Description correctly (showing "-") because it wasn't resolving the `currentRevision` correctly or receiving unwrapped data.
|
||||
- **Fix:**
|
||||
- Updated `CorrespondenceDetail` to explicitly try finding `isCurrent` revision or fallback to index 0.
|
||||
@@ -18,6 +20,7 @@
|
||||
- **Outcome:** Detail page now correctly shows Subject, Description, and Status from the current revision.
|
||||
|
||||
### 3. Edit Functionality
|
||||
|
||||
- **Issue:** Clicking "Edit" led to a 404/Blank page.
|
||||
- **Fix:**
|
||||
- Created `app/(dashboard)/correspondences/[id]/edit/page.tsx`.
|
||||
@@ -25,6 +28,7 @@
|
||||
- **Outcome:** Users can now edit existing DRAFT correspondences.
|
||||
|
||||
## 📂 Modified Files
|
||||
|
||||
- `backend/src/modules/correspondence/correspondence.service.ts`
|
||||
- `frontend/types/correspondence.ts`
|
||||
- `frontend/components/correspondences/list.tsx`
|
||||
@@ -34,6 +38,7 @@
|
||||
- `frontend/app/(dashboard)/correspondences/[id]/edit/page.tsx` (Created)
|
||||
|
||||
## ✅ Verification
|
||||
|
||||
- Validated List View shows revisions.
|
||||
- Validated Detail View loads data.
|
||||
- Validated Edit Page loads data and submits updates.
|
||||
|
||||
Reference in New Issue
Block a user