260322:1648 Correct Coresspondence / Doing RFA / Correct CI

backend/src/modules/circulation/circulation-workflow.service.ts

@@ -86,7 +86,7 @@ export class CirculationWorkflowService {
       };
     } catch (error) {
       await queryRunner.rollbackTransaction();
-      this.logger.error(`Failed to start circulation: ${error}`);
+      this.logger.error(`Failed to start circulation: ${String(error)}`);
       throw error;
     } finally {
       await queryRunner.release();
@@ -114,7 +114,7 @@ export class CirculationWorkflowService {
     const instance = await this.workflowEngine.getInstanceById(instanceId);
     if (instance && instance.entityType === 'circulation') {
       const circulation = await this.circulationRepo.findOne({
-        where: { id: parseInt(instance.entityId) },
+        where: { id: Number(instance.entityId) },
       });
       if (circulation) {
         await this.syncStatus(circulation, result.nextState);

backend/src/modules/circulation/circulation.service.ts

@@ -5,7 +5,7 @@ import {
   ForbiddenException,
 } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
-import { Repository, DataSource, Not } from 'typeorm';
+import { Repository, DataSource } from 'typeorm';
 
 import { Circulation } from './entities/circulation.entity';
 import { CirculationRouting } from './entities/circulation-routing.entity';
@@ -95,7 +95,7 @@ export class CirculationService {
   }
 
   async findAll(searchDto: SearchCirculationDto, user: User) {
-    const { search, status, page = 1, limit = 20 } = searchDto;
+    const { status, page = 1, limit = 20 } = searchDto;
     const query = this.circulationRepo
       .createQueryBuilder('c')
       .leftJoinAndSelect('c.creator', 'creator')