260220:1504 20260220 TASK-BEFE-001 Refactor by ADR-014

frontend/app/(admin)/admin/doc-control/numbering/page.tsx

@@ -6,21 +6,15 @@ import { Card } from '@/components/ui/card';
 import { Badge } from '@/components/ui/badge';
 import { Tabs, TabsContent, TabsList, TabsTrigger } from '@/components/ui/tabs';
 import { Plus, Edit, Play } from 'lucide-react';
-import { numberingApi, NumberingTemplate } from '@/lib/api/numbering';
+import { NumberingTemplate } from '@/lib/api/numbering';
+import { useTemplates, useSaveTemplate } from '@/hooks/use-numbering';
 import { TemplateEditor } from '@/components/numbering/template-editor';
 import { SequenceViewer } from '@/components/numbering/sequence-viewer';
 import { TemplateTester } from '@/components/numbering/template-tester';
 import { toast } from 'sonner';
-import {
-  Select,
-  SelectContent,
-  SelectItem,
-  SelectTrigger,
-  SelectValue,
-} from "@/components/ui/select";
+import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select';
 import { useProjects, useCorrespondenceTypes, useContracts, useDisciplines } from '@/hooks/use-master-data';
 
-
 import { ManualOverrideForm } from '@/components/numbering/manual-override-form';
 import { MetricsDashboard } from '@/components/numbering/metrics-dashboard';
 import { AuditLogsTable } from '@/components/numbering/audit-logs-table';
@@ -28,13 +22,10 @@ import { VoidReplaceForm } from '@/components/numbering/void-replace-form';
 import { CancelNumberForm } from '@/components/numbering/cancel-number-form';
 import { BulkImportForm } from '@/components/numbering/bulk-import-form';
 
-
 export default function NumberingPage() {
   const { data: projects = [] } = useProjects();
-  const [selectedProjectId, setSelectedProjectId] = useState("1");
-  const [activeTab, setActiveTab] = useState("templates");
-
-  const [templates, setTemplates] = useState<NumberingTemplate[]>([]);
+  const [selectedProjectId, setSelectedProjectId] = useState('1');
+  const [activeTab, setActiveTab] = useState('templates');
 
   // View states
   const [isEditing, setIsEditing] = useState(false);
@@ -42,7 +33,9 @@ export default function NumberingPage() {
   const [isTesting, setIsTesting] = useState(false);
   const [testTemplate, setTestTemplate] = useState<NumberingTemplate | null>(null);
 
-  const selectedProjectName = projects.find((p: { id: number; projectName: string }) => p.id.toString() === selectedProjectId)?.projectName || 'Unknown Project';
+  const selectedProjectName =
+    projects.find((p: { id: number; projectName: string }) => p.id.toString() === selectedProjectId)?.projectName ||
+    'Unknown Project';
 
   // Master Data
   const { data: correspondenceTypes = [] } = useCorrespondenceTypes();
@@ -50,189 +43,168 @@ export default function NumberingPage() {
   const contractId = contracts[0]?.id;
   const { data: disciplines = [] } = useDisciplines(contractId);
 
-  const loadTemplates = async () => {
-    try {
-        const response = await numberingApi.getTemplates();
-        // Handle wrapped response { data: [...] } or direct array
-        const data = Array.isArray(response) ? response : (response as { data?: NumberingTemplate[] })?.data ?? [];
-        setTemplates(data);
-    } catch {
-        toast.error("Failed to load templates");
-        setTemplates([]);
-    }
-  };
+  const { data: templateResponse, isLoading: isLoadingTemplates } = useTemplates();
+  const saveTemplateMutation = useSaveTemplate();
 
-  useEffect(() => {
-    loadTemplates();
-  }, []);
+  // Extract templates array from response (handles both direct array and { data: array } formats)
+  const templates: NumberingTemplate[] = Array.isArray(templateResponse)
+    ? templateResponse
+    : ((templateResponse as any)?.data ?? []);
 
   const handleEdit = (template?: NumberingTemplate) => {
-      setActiveTemplate(template);
-      setIsEditing(true);
+    setActiveTemplate(template);
+    setIsEditing(true);
   };
 
   const handleSave = async (data: Partial<NumberingTemplate>) => {
-      try {
-          await numberingApi.saveTemplate(data);
-          toast.success(data.id ? "Template updated" : "Template created");
-          setIsEditing(false);
-          loadTemplates();
-      } catch {
-          toast.error("Failed to save template");
-      }
+    try {
+      await saveTemplateMutation.mutateAsync(data);
+      toast.success(data.id ? 'Template updated' : 'Template created');
+      setIsEditing(false);
+    } catch {
+      toast.error('Failed to save template');
+    }
   };
 
   const handleTest = (template: NumberingTemplate) => {
-      setTestTemplate(template);
-      setIsTesting(true);
+    setTestTemplate(template);
+    setIsTesting(true);
   };
 
-
-
   if (isEditing) {
-      return (
-          <div className="p-6 max-w-4xl mx-auto animate-in fade-in slide-in-from-bottom-4">
-              <TemplateEditor
-                  template={activeTemplate}
-                  projectId={Number(selectedProjectId)}
-                  projectName={selectedProjectName}
-                  correspondenceTypes={correspondenceTypes}
-                  disciplines={disciplines}
-                  onSave={handleSave}
-                  onCancel={() => setIsEditing(false)}
-              />
-          </div>
-      );
+    return (
+      <div className="p-6 max-w-4xl mx-auto animate-in fade-in slide-in-from-bottom-4">
+        <TemplateEditor
+          template={activeTemplate}
+          projectId={Number(selectedProjectId)}
+          projectName={selectedProjectName}
+          correspondenceTypes={correspondenceTypes}
+          disciplines={disciplines}
+          onSave={handleSave}
+          onCancel={() => setIsEditing(false)}
+        />
+      </div>
+    );
   }
 
   return (
     <div className="p-6 space-y-6">
       <div className="flex justify-between items-center">
         <div>
-          <h1 className="text-3xl font-bold tracking-tight">
-            Document Numbering
-          </h1>
-          <p className="text-muted-foreground mt-1">
-            Manage numbering templates, audit logs, and tools
-          </p>
+          <h1 className="text-3xl font-bold tracking-tight">Document Numbering</h1>
+          <p className="text-muted-foreground mt-1">Manage numbering templates, audit logs, and tools</p>
         </div>
         <div className="flex gap-2">
-            <Select value={selectedProjectId} onValueChange={setSelectedProjectId}>
-                <SelectTrigger className="w-[200px]">
-                    <SelectValue placeholder="Select Project" />
-                </SelectTrigger>
-                <SelectContent>
-                    {projects.map((project: { id: number; projectCode: string; projectName: string }) => (
-                        <SelectItem key={project.id} value={project.id.toString()}>
-                            {project.projectCode} - {project.projectName}
-                        </SelectItem>
-                    ))}
-                </SelectContent>
-            </Select>
+          <Select value={selectedProjectId} onValueChange={setSelectedProjectId}>
+            <SelectTrigger className="w-[200px]">
+              <SelectValue placeholder="Select Project" />
+            </SelectTrigger>
+            <SelectContent>
+              {projects.map((project: { id: number; projectCode: string; projectName: string }) => (
+                <SelectItem key={project.id} value={project.id.toString()}>
+                  {project.projectCode} - {project.projectName}
+                </SelectItem>
+              ))}
+            </SelectContent>
+          </Select>
         </div>
       </div>
 
       <Tabs value={activeTab} onValueChange={setActiveTab} className="space-y-4">
-          <TabsList>
-              <TabsTrigger value="templates">Templates</TabsTrigger>
-              <TabsTrigger value="metrics">Metrics & Audit</TabsTrigger>
-              <TabsTrigger value="tools">Admin Tools</TabsTrigger>
-          </TabsList>
+        <TabsList>
+          <TabsTrigger value="templates">Templates</TabsTrigger>
+          <TabsTrigger value="metrics">Metrics & Audit</TabsTrigger>
+          <TabsTrigger value="tools">Admin Tools</TabsTrigger>
+        </TabsList>
 
-          <TabsContent value="templates" className="space-y-4">
-               <div className="flex justify-end">
-                    <Button onClick={() => handleEdit(undefined)}>
-                        <Plus className="mr-2 h-4 w-4" />
-                        New Template
-                    </Button>
-               </div>
+        <TabsContent value="templates" className="space-y-4">
+          <div className="flex justify-end">
+            <Button onClick={() => handleEdit(undefined)}>
+              <Plus className="mr-2 h-4 w-4" />
+              New Template
+            </Button>
+          </div>
 
-               <div className="grid lg:grid-cols-3 gap-6">
-                  <div className="lg:col-span-2 space-y-4">
-                    <div className="grid gap-4">
-                        {templates
-                          .filter(t => !t.projectId || t.projectId === Number(selectedProjectId))
-                          .map((template) => (
-                        <Card key={template.id} className="p-6 hover:shadow-md transition-shadow">
-                            <div className="flex justify-between items-start">
-                            <div className="flex-1">
-                                <div className="flex items-center gap-3 mb-2">
-                                <h3 className="text-lg font-semibold">
-                                    {template.correspondenceType?.typeName || 'Default Format'}
-                                </h3>
-                                <Badge variant="outline" className="text-xs">
-                                     {template.project?.projectCode || selectedProjectName}
-                                </Badge>
-                                {template.description && <Badge variant="secondary">{template.description}</Badge>}
-                                </div>
+          <div className="grid lg:grid-cols-3 gap-6">
+            <div className="lg:col-span-2 space-y-4">
+              <div className="grid gap-4">
+                {templates
+                  .filter((t) => !t.projectId || t.projectId === Number(selectedProjectId))
+                  .map((template) => (
+                    <Card key={template.id} className="p-6 hover:shadow-md transition-shadow">
+                      <div className="flex justify-between items-start">
+                        <div className="flex-1">
+                          <div className="flex items-center gap-3 mb-2">
+                            <h3 className="text-lg font-semibold">
+                              {template.correspondenceType?.typeName || 'Default Format'}
+                            </h3>
+                            <Badge variant="outline" className="text-xs">
+                              {template.project?.projectCode || selectedProjectName}
+                            </Badge>
+                            {template.description && <Badge variant="secondary">{template.description}</Badge>}
+                          </div>
 
-                                <div className="bg-slate-100 dark:bg-slate-900 rounded px-3 py-2 mb-3 font-mono text-sm inline-block border">
-                                {template.formatTemplate}
-                                </div>
+                          <div className="bg-slate-100 dark:bg-slate-900 rounded px-3 py-2 mb-3 font-mono text-sm inline-block border">
+                            {template.formatTemplate}
+                          </div>
 
-                                <div className="grid grid-cols-2 gap-4 text-sm mt-2">
-                                    <div>
-                                        <span className="text-muted-foreground">Type Code: </span>
-                                        <span className="font-medium font-mono text-green-600 dark:text-green-400">
-                                        {template.correspondenceType?.typeCode || 'DEFAULT'}
-                                        </span>
-                                    </div>
-                                    <div>
-                                        <span className="text-muted-foreground">Reset: </span>
-                                        <span>
-                                        {template.resetSequenceYearly ? 'Annually' : 'Continuous'}
-                                        </span>
-                                    </div>
-                                </div>
+                          <div className="grid grid-cols-2 gap-4 text-sm mt-2">
+                            <div>
+                              <span className="text-muted-foreground">Type Code: </span>
+                              <span className="font-medium font-mono text-green-600 dark:text-green-400">
+                                {template.correspondenceType?.typeCode || 'DEFAULT'}
+                              </span>
                             </div>
-
-                            <div className="flex flex-col gap-2">
-                                <Button variant="outline" size="sm" onClick={() => handleEdit(template)}>
-                                <Edit className="mr-2 h-4 w-4" />
-                                Edit
-                                </Button>
-                                <Button variant="outline" size="sm" onClick={() => handleTest(template)}>
-                                <Play className="mr-2 h-4 w-4" />
-                                Test
-                                </Button>
+                            <div>
+                              <span className="text-muted-foreground">Reset: </span>
+                              <span>{template.resetSequenceYearly ? 'Annually' : 'Continuous'}</span>
                             </div>
-                            </div>
-                        </Card>
-                        ))}
-                    </div>
-                  </div>
+                          </div>
+                        </div>
 
-                  <div className="space-y-4">
-                     <SequenceViewer />
-                  </div>
+                        <div className="flex flex-col gap-2">
+                          <Button variant="outline" size="sm" onClick={() => handleEdit(template)}>
+                            <Edit className="mr-2 h-4 w-4" />
+                            Edit
+                          </Button>
+                          <Button variant="outline" size="sm" onClick={() => handleTest(template)}>
+                            <Play className="mr-2 h-4 w-4" />
+                            Test
+                          </Button>
+                        </div>
+                      </div>
+                    </Card>
+                  ))}
               </div>
-          </TabsContent>
+            </div>
 
-          <TabsContent value="metrics" className="space-y-4">
-              <MetricsDashboard />
-              <div className="mt-6">
-                <h3 className="text-lg font-medium mb-4">Audit Logs</h3>
-                <AuditLogsTable />
-              </div>
-          </TabsContent>
+            <div className="space-y-4">
+              <SequenceViewer />
+            </div>
+          </div>
+        </TabsContent>
 
-          <TabsContent value="tools" className="space-y-4">
-              <div className="grid gap-4 md:grid-cols-2">
-                  <ManualOverrideForm projectId={Number(selectedProjectId)} />
-                  <VoidReplaceForm projectId={Number(selectedProjectId)} />
-                  <CancelNumberForm />
-                  <div className="md:col-span-2">
-                     <BulkImportForm projectId={Number(selectedProjectId)} />
-                  </div>
-              </div>
-          </TabsContent>
+        <TabsContent value="metrics" className="space-y-4">
+          <MetricsDashboard />
+          <div className="mt-6">
+            <h3 className="text-lg font-medium mb-4">Audit Logs</h3>
+            <AuditLogsTable />
+          </div>
+        </TabsContent>
+
+        <TabsContent value="tools" className="space-y-4">
+          <div className="grid gap-4 md:grid-cols-2">
+            <ManualOverrideForm projectId={Number(selectedProjectId)} />
+            <VoidReplaceForm projectId={Number(selectedProjectId)} />
+            <CancelNumberForm />
+            <div className="md:col-span-2">
+              <BulkImportForm projectId={Number(selectedProjectId)} />
+            </div>
+          </div>
+        </TabsContent>
       </Tabs>
 
-      <TemplateTester
-          open={isTesting}
-          onOpenChange={setIsTesting}
-          template={testTemplate}
-      />
+      <TemplateTester open={isTesting} onOpenChange={setIsTesting} template={testTemplate} />
     </div>
   );
 }

frontend/app/(admin)/admin/doc-control/reference/disciplines/page.tsx

@@ -1,64 +1,43 @@
-"use client";
+'use client';
 
-import { GenericCrudTable } from "@/components/admin/reference/generic-crud-table";
-import { masterDataService } from "@/lib/services/master-data.service";
-import { contractService } from "@/lib/services/contract.service";
-import { ColumnDef } from "@tanstack/react-table";
-import { useState, useEffect } from "react";
-import {
-  Select,
-  SelectContent,
-  SelectItem,
-  SelectTrigger,
-  SelectValue,
-} from "@/components/ui/select";
+import { GenericCrudTable } from '@/components/admin/reference/generic-crud-table';
+import { masterDataService } from '@/lib/services/master-data.service';
+import { useContracts } from '@/hooks/use-master-data';
+import { ColumnDef } from '@tanstack/react-table';
+import { useState } from 'react';
+import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select';
 
 export default function DisciplinesPage() {
-  const [contracts, setContracts] = useState<any[]>([]);
-  const [selectedContractId, setSelectedContractId] = useState<string | null>(
-    null
-  );
+  const [selectedContractId, setSelectedContractId] = useState<string | null>(null);
 
-  useEffect(() => {
-    // Fetch contracts for filter and form options
-    contractService.getAll().then((data) => {
-      setContracts(Array.isArray(data) ? data : []);
-    }).catch(err => {
-        console.error("Failed to load contracts:", err);
-        setContracts([]);
-    });
-  }, []);
+  const { data: contractsData = [] } = useContracts();
+  // Ensure we consistently use an array
+  const contracts = Array.isArray(contractsData) ? contractsData : [];
 
   const columns: ColumnDef<any>[] = [
     {
-      accessorKey: "disciplineCode",
-      header: "Code",
-      cell: ({ row }) => (
-        <span className="font-mono font-bold">
-          {row.getValue("disciplineCode")}
-        </span>
-      ),
+      accessorKey: 'disciplineCode',
+      header: 'Code',
+      cell: ({ row }) => <span className="font-mono font-bold">{row.getValue('disciplineCode')}</span>,
     },
     {
-      accessorKey: "codeNameTh",
-      header: "Name (TH)",
+      accessorKey: 'codeNameTh',
+      header: 'Name (TH)',
     },
     {
-      accessorKey: "codeNameEn",
-      header: "Name (EN)",
+      accessorKey: 'codeNameEn',
+      header: 'Name (EN)',
     },
     {
-      accessorKey: "isActive",
-      header: "Status",
+      accessorKey: 'isActive',
+      header: 'Status',
       cell: ({ row }) => (
         <span
           className={`px-2 py-1 rounded-full text-xs ${
-            row.getValue("isActive")
-              ? "bg-green-100 text-green-800"
-              : "bg-red-100 text-red-800"
+            row.getValue('isActive') ? 'bg-green-100 text-green-800' : 'bg-red-100 text-red-800'
           }`}
         >
-          {row.getValue("isActive") ? "Active" : "Inactive"}
+          {row.getValue('isActive') ? 'Active' : 'Inactive'}
         </span>
       ),
     },
@@ -75,23 +54,17 @@ export default function DisciplinesPage() {
         entityName="Discipline"
         title="Disciplines Management"
         description="Manage system disciplines (e.g., ARCH, STR, MEC)"
-        queryKey={["disciplines", selectedContractId ?? "all"]}
-        fetchFn={() =>
-          masterDataService.getDisciplines(
-            selectedContractId ? parseInt(selectedContractId) : undefined
-          )
-        }
+        queryKey={['disciplines', selectedContractId ?? 'all']}
+        fetchFn={() => masterDataService.getDisciplines(selectedContractId ? parseInt(selectedContractId) : undefined)}
         createFn={(data) => masterDataService.createDiscipline(data)}
-        updateFn={(id, data) => Promise.reject("Not implemented yet")} // Update endpoint needs to be verified/added if missing
+        updateFn={(id, data) => Promise.reject('Not implemented yet')} // Update endpoint needs to be verified/added if missing
         deleteFn={(id) => masterDataService.deleteDiscipline(id)}
         columns={columns}
         filters={
           <div className="w-[300px]">
             <Select
-              value={selectedContractId || "all"}
-              onValueChange={(val) =>
-                setSelectedContractId(val === "all" ? null : val)
-              }
+              value={selectedContractId || 'all'}
+              onValueChange={(val) => setSelectedContractId(val === 'all' ? null : val)}
             >
               <SelectTrigger>
                 <SelectValue placeholder="Filter by Contract" />
@@ -109,26 +82,26 @@ export default function DisciplinesPage() {
         }
         fields={[
           {
-            name: "contractId",
-            label: "Contract",
-            type: "select",
+            name: 'contractId',
+            label: 'Contract',
+            type: 'select',
             required: true,
             options: contractOptions,
           },
           {
-            name: "disciplineCode",
-            label: "Code",
-            type: "text",
+            name: 'disciplineCode',
+            label: 'Code',
+            type: 'text',
             required: true,
           },
           {
-            name: "codeNameTh",
-            label: "Name (TH)",
-            type: "text",
+            name: 'codeNameTh',
+            label: 'Name (TH)',
+            type: 'text',
             required: true,
           },
-          { name: "codeNameEn", label: "Name (EN)", type: "text" },
-          { name: "isActive", label: "Active", type: "checkbox" },
+          { name: 'codeNameEn', label: 'Name (EN)', type: 'text' },
+          { name: 'isActive', label: 'Active', type: 'checkbox' },
         ]}
       />
     </div>

frontend/app/(admin)/admin/doc-control/reference/rfa-types/page.tsx

@@ -1,66 +1,47 @@
-"use client";
+'use client';
 
-import { GenericCrudTable } from "@/components/admin/reference/generic-crud-table";
-import { masterDataService } from "@/lib/services/master-data.service";
-import { contractService } from "@/lib/services/contract.service";
-import { ColumnDef } from "@tanstack/react-table";
-import { useState, useEffect } from "react";
-import {
-  Select,
-  SelectContent,
-  SelectItem,
-  SelectTrigger,
-  SelectValue,
-} from "@/components/ui/select";
+import { GenericCrudTable } from '@/components/admin/reference/generic-crud-table';
+import { masterDataService } from '@/lib/services/master-data.service';
+import { useContracts } from '@/hooks/use-master-data';
+import { ColumnDef } from '@tanstack/react-table';
+import { useState } from 'react';
+import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select';
 
 export default function RfaTypesPage() {
-  const [contracts, setContracts] = useState<any[]>([]);
-  const [selectedContractId, setSelectedContractId] = useState<string | null>(
-    null
-  );
+  const [selectedContractId, setSelectedContractId] = useState<string | null>(null);
 
-  useEffect(() => {
-    // Fetch contracts for filter and form options
-    contractService.getAll().then((data) => {
-      setContracts(Array.isArray(data) ? data : []);
-    }).catch(err => {
-        console.error("Failed to load contracts:", err);
-        setContracts([]);
-    });
-  }, []);
+  const { data: contractsData = [] } = useContracts();
+  // Ensure we consistently use an array
+  const contracts = Array.isArray(contractsData) ? contractsData : [];
 
   const columns: ColumnDef<any>[] = [
     {
-      accessorKey: "typeCode",
-      header: "Code",
-      cell: ({ row }) => (
-        <span className="font-mono font-bold">{row.getValue("typeCode")}</span>
-      ),
+      accessorKey: 'typeCode',
+      header: 'Code',
+      cell: ({ row }) => <span className="font-mono font-bold">{row.getValue('typeCode')}</span>,
     },
     {
-      accessorKey: "typeNameTh",
-      header: "Name (TH)",
+      accessorKey: 'typeNameTh',
+      header: 'Name (TH)',
     },
     {
-      accessorKey: "typeNameEn",
-      header: "Name (EN)",
+      accessorKey: 'typeNameEn',
+      header: 'Name (EN)',
     },
     {
-      accessorKey: "remark",
-      header: "Remark",
+      accessorKey: 'remark',
+      header: 'Remark',
     },
     {
-      accessorKey: "isActive",
-      header: "Status",
+      accessorKey: 'isActive',
+      header: 'Status',
       cell: ({ row }) => (
         <span
           className={`px-2 py-1 rounded-full text-xs ${
-            row.getValue("isActive")
-              ? "bg-green-100 text-green-800"
-              : "bg-red-100 text-red-800"
+            row.getValue('isActive') ? 'bg-green-100 text-green-800' : 'bg-red-100 text-red-800'
           }`}
         >
-          {row.getValue("isActive") ? "Active" : "Inactive"}
+          {row.getValue('isActive') ? 'Active' : 'Inactive'}
         </span>
       ),
     },
@@ -76,12 +57,8 @@ export default function RfaTypesPage() {
       <GenericCrudTable
         entityName="RFA Type"
         title="RFA Types Management"
-        queryKey={["rfa-types", selectedContractId ?? "all"]}
-        fetchFn={() =>
-          masterDataService.getRfaTypes(
-            selectedContractId ? parseInt(selectedContractId) : undefined
-          )
-        }
+        queryKey={['rfa-types', selectedContractId ?? 'all']}
+        fetchFn={() => masterDataService.getRfaTypes(selectedContractId ? parseInt(selectedContractId) : undefined)}
         createFn={(data) => masterDataService.createRfaType(data)}
         updateFn={(id, data) => masterDataService.updateRfaType(id, data)}
         deleteFn={(id) => masterDataService.deleteRfaType(id)}
@@ -89,10 +66,8 @@ export default function RfaTypesPage() {
         filters={
           <div className="w-[300px]">
             <Select
-              value={selectedContractId || "all"}
-              onValueChange={(val) =>
-                setSelectedContractId(val === "all" ? null : val)
-              }
+              value={selectedContractId || 'all'}
+              onValueChange={(val) => setSelectedContractId(val === 'all' ? null : val)}
             >
               <SelectTrigger>
                 <SelectValue placeholder="Filter by Contract" />
@@ -110,17 +85,17 @@ export default function RfaTypesPage() {
         }
         fields={[
           {
-            name: "contractId",
-            label: "Contract",
-            type: "select",
+            name: 'contractId',
+            label: 'Contract',
+            type: 'select',
             required: true,
             options: contractOptions,
           },
-          { name: "typeCode", label: "Code", type: "text", required: true },
-          { name: "typeNameTh", label: "Name (TH)", type: "text", required: true },
-          { name: "typeNameEn", label: "Name (EN)", type: "text" },
-          { name: "remark", label: "Remark", type: "textarea" },
-          { name: "isActive", label: "Active", type: "checkbox" },
+          { name: 'typeCode', label: 'Code', type: 'text', required: true },
+          { name: 'typeNameTh', label: 'Name (TH)', type: 'text', required: true },
+          { name: 'typeNameEn', label: 'Name (EN)', type: 'text' },
+          { name: 'remark', label: 'Remark', type: 'textarea' },
+          { name: 'isActive', label: 'Active', type: 'checkbox' },
         ]}
       />
     </div>

frontend/app/(admin)/admin/doc-control/workflows/[id]/edit/page.tsx

@@ -11,8 +11,9 @@ import { Label } from '@/components/ui/label';
 import { Textarea } from '@/components/ui/textarea';
 import { Card } from '@/components/ui/card';
 import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select';
-import { workflowApi } from '@/lib/api/workflows';
-import { Workflow, CreateWorkflowDto } from '@/types/workflow';
+import { useWorkflowDefinition, useCreateWorkflowDefinition, useUpdateWorkflowDefinition } from '@/hooks/use-workflows';
+import { Workflow } from '@/types/workflow';
+import { CreateWorkflowDefinitionDto } from '@/types/dto/workflow-engine/workflow-engine.dto';
 import { toast } from 'sonner';
 import { Save, ArrowLeft, Loader2 } from 'lucide-react';
 import Link from 'next/link';
@@ -22,8 +23,6 @@ export default function WorkflowEditPage() {
   const router = useRouter();
   const id = params?.id === 'new' ? null : Number(params?.id);
 
-  const [loading, setLoading] = useState(!!id);
-  const [saving, setSaving] = useState(false);
   const [workflowData, setWorkflowData] = useState<Partial<Workflow>>({
     workflowName: '',
     description: '',
@@ -32,84 +31,77 @@ export default function WorkflowEditPage() {
     isActive: true,
   });
 
+  const { data: fetchedWorkflow, isLoading: loadingWorkflow } = useWorkflowDefinition(id as number);
+  const createMutation = useCreateWorkflowDefinition();
+  const updateMutation = useUpdateWorkflowDefinition();
+
   useEffect(() => {
-    if (id) {
-        const fetchWorkflow = async () => {
-            try {
-                const data = await workflowApi.getWorkflow(id);
-                if (data) {
-                    setWorkflowData(data);
-                } else {
-                    toast.error("Workflow not found");
-                    router.push('/admin/workflows');
-                }
-            } catch (error) {
-                toast.error("Failed to load workflow");
-                console.error(error);
-            } finally {
-                setLoading(false);
-            }
-        };
-        fetchWorkflow();
+    if (fetchedWorkflow) {
+      setWorkflowData(fetchedWorkflow);
     }
-  }, [id, router]);
+  }, [fetchedWorkflow]);
+
+  const loading = (!!id && loadingWorkflow) || createMutation.isPending || updateMutation.isPending;
+  const saving = createMutation.isPending || updateMutation.isPending;
 
   const handleSave = async () => {
     if (!workflowData.workflowName) {
-        toast.error("Workflow name is required");
-        return;
+      toast.error('Workflow name is required');
+      return;
     }
 
-    setSaving(true);
     try {
-        const dto: CreateWorkflowDto = {
-            workflowName: workflowData.workflowName || '',
-            description: workflowData.description || '',
-            workflowType: workflowData.workflowType || 'CORRESPONDENCE',
-            dslDefinition: workflowData.dslDefinition || '',
-        };
+      const dto: CreateWorkflowDefinitionDto = {
+        workflow_code: workflowData.workflowType || 'CORRESPONDENCE',
+        dsl: {
+          workflowName: workflowData.workflowName,
+          description: workflowData.description,
+          dslDefinition: workflowData.dslDefinition,
+        },
+        is_active: workflowData.isActive,
+      };
 
-        if (id) {
-            await workflowApi.updateWorkflow(id, dto);
-            toast.success("Workflow updated successfully");
-        } else {
-            await workflowApi.createWorkflow(dto);
-            toast.success("Workflow created successfully");
-            router.push('/admin/workflows');
-        }
+      if (id) {
+        await updateMutation.mutateAsync({ id, data: dto });
+        toast.success('Workflow updated successfully');
+      } else {
+        await createMutation.mutateAsync(dto);
+        toast.success('Workflow created successfully');
+        router.push('/admin/workflows');
+      }
     } catch (error) {
-        toast.error("Failed to save workflow");
-        console.error(error);
-    } finally {
-        setSaving(false);
+      toast.error('Failed to save workflow');
+      console.error(error);
     }
   };
 
   if (loading) {
-      return (
-          <div className="flex items-center justify-center h-screen">
-              <Loader2 className="h-8 w-8 animate-spin" />
-          </div>
-      );
+    return (
+      <div className="flex items-center justify-center h-screen">
+        <Loader2 className="h-8 w-8 animate-spin" />
+      </div>
+    );
   }
 
   return (
     <div className="p-6 space-y-6 max-w-7xl mx-auto">
       <div className="flex justify-between items-center">
         <div className="flex items-center gap-4">
-             <Link href="/admin/workflows">
-                <Button variant="ghost" size="icon">
-                    <ArrowLeft className="h-5 w-5" />
-                </Button>
-            </Link>
-            <div>
-                <h1 className="text-3xl font-bold">{id ? 'Edit Workflow' : 'New Workflow'}</h1>
-                <p className="text-muted-foreground">{id ? `Version ${workflowData.version}` : 'Create a new workflow definition'}</p>
-            </div>
+          <Link href="/admin/workflows">
+            <Button variant="ghost" size="icon">
+              <ArrowLeft className="h-5 w-5" />
+            </Button>
+          </Link>
+          <div>
+            <h1 className="text-3xl font-bold">{id ? 'Edit Workflow' : 'New Workflow'}</h1>
+            <p className="text-muted-foreground">
+              {id ? `Version ${workflowData.version}` : 'Create a new workflow definition'}
+            </p>
+          </div>
         </div>
         <div className="flex gap-2">
           <Link href="/admin/workflows">
-             <Button variant="outline">Cancel</Button>
+            <Button variant="outline">Cancel</Button>
           </Link>
           <Button onClick={handleSave} disabled={saving}>
             {saving && <Loader2 className="mr-2 h-4 w-4 animate-spin" />}
@@ -121,84 +113,82 @@ export default function WorkflowEditPage() {
 
       <div className="grid grid-cols-1 lg:grid-cols-3 gap-6">
         <div className="lg:col-span-1 space-y-6">
-            <Card className="p-6">
-                <div className="grid gap-4">
-                <div>
-                    <Label htmlFor="name">Workflow Name *</Label>
-                    <Input
-                    id="name"
-                    value={workflowData.workflowName}
-                    onChange={(e) =>
-                        setWorkflowData({
-                        ...workflowData,
-                        workflowName: e.target.value,
-                        })
-                    }
-                    placeholder="e.g. Standard RFA Workflow"
-                    />
-                </div>
+          <Card className="p-6">
+            <div className="grid gap-4">
+              <div>
+                <Label htmlFor="name">Workflow Name *</Label>
+                <Input
+                  id="name"
+                  value={workflowData.workflowName}
+                  onChange={(e) =>
+                    setWorkflowData({
+                      ...workflowData,
+                      workflowName: e.target.value,
+                    })
+                  }
+                  placeholder="e.g. Standard RFA Workflow"
+                />
+              </div>
 
-                <div>
-                    <Label htmlFor="desc">Description</Label>
-                    <Textarea
-                    id="desc"
-                    value={workflowData.description}
-                    onChange={(e) =>
-                        setWorkflowData({
-                        ...workflowData,
-                        description: e.target.value,
-                        })
-                    }
-                    placeholder="Describe the purpose of this workflow"
-                    />
-                </div>
+              <div>
+                <Label htmlFor="desc">Description</Label>
+                <Textarea
+                  id="desc"
+                  value={workflowData.description}
+                  onChange={(e) =>
+                    setWorkflowData({
+                      ...workflowData,
+                      description: e.target.value,
+                    })
+                  }
+                  placeholder="Describe the purpose of this workflow"
+                />
+              </div>
 
-                <div>
-                    <Label htmlFor="type">Workflow Type</Label>
-                    <Select
-                    value={workflowData.workflowType}
-                    onValueChange={(value: Workflow['workflowType']) =>
-                        setWorkflowData({ ...workflowData, workflowType: value })
-                    }
-                    >
-                    <SelectTrigger>
-                        <SelectValue placeholder="Select type" />
-                    </SelectTrigger>
-                    <SelectContent>
-                        <SelectItem value="CORRESPONDENCE">Correspondence</SelectItem>
-                        <SelectItem value="RFA">RFA</SelectItem>
-                        <SelectItem value="DRAWING">Drawing</SelectItem>
-                    </SelectContent>
-                    </Select>
-                </div>
-                </div>
-            </Card>
+              <div>
+                <Label htmlFor="type">Workflow Type</Label>
+                <Select
+                  value={workflowData.workflowType}
+                  onValueChange={(value: Workflow['workflowType']) =>
+                    setWorkflowData({ ...workflowData, workflowType: value })
+                  }
+                >
+                  <SelectTrigger>
+                    <SelectValue placeholder="Select type" />
+                  </SelectTrigger>
+                  <SelectContent>
+                    <SelectItem value="CORRESPONDENCE">Correspondence</SelectItem>
+                    <SelectItem value="RFA">RFA</SelectItem>
+                    <SelectItem value="DRAWING">Drawing</SelectItem>
+                  </SelectContent>
+                </Select>
+              </div>
+            </div>
+          </Card>
         </div>
 
         <div className="lg:col-span-2">
-             <Tabs defaultValue="dsl" className="w-full">
-                <TabsList className="w-full justify-start">
-                <TabsTrigger value="dsl">DSL Editor</TabsTrigger>
-                <TabsTrigger value="visual">Visual Builder</TabsTrigger>
-                </TabsList>
+          <Tabs defaultValue="dsl" className="w-full">
+            <TabsList className="w-full justify-start">
+              <TabsTrigger value="dsl">DSL Editor</TabsTrigger>
+              <TabsTrigger value="visual">Visual Builder</TabsTrigger>
+            </TabsList>
 
-                <TabsContent value="dsl" className="mt-4">
-                <DSLEditor
-                    initialValue={workflowData.dslDefinition}
-                    onChange={(value) =>
-                       setWorkflowData({ ...workflowData, dslDefinition: value })
-                    }
-                />
-                </TabsContent>
+            <TabsContent value="dsl" className="mt-4">
+              <DSLEditor
+                initialValue={workflowData.dslDefinition}
+                onChange={(value) => setWorkflowData({ ...workflowData, dslDefinition: value })}
+              />
+            </TabsContent>
 
-                <TabsContent value="visual" className="mt-4 h-[600px]">
-                <VisualWorkflowBuilder
-                   dslString={workflowData.dslDefinition}
-                   onDslChange={(newDsl) => setWorkflowData({ ...workflowData, dslDefinition: newDsl })}
-                   onSave={() => toast.info("Visual state saving not implemented in this demo")}
-                />
-                </TabsContent>
-            </Tabs>
+            <TabsContent value="visual" className="mt-4 h-[600px]">
+              <VisualWorkflowBuilder
+                dslString={workflowData.dslDefinition}
+                onDslChange={(newDsl) => setWorkflowData({ ...workflowData, dslDefinition: newDsl })}
+                onSave={() => toast.info('Visual state saving not implemented in this demo')}
+              />
+            </TabsContent>
+          </Tabs>
         </div>
       </div>
     </div>

frontend/app/(admin)/admin/doc-control/workflows/page.tsx

@@ -1,13 +1,13 @@
-"use client";
+'use client';
 
-import { useState, useEffect } from "react";
-import { Button } from "@/components/ui/button";
-import { Card } from "@/components/ui/card";
-import { Badge } from "@/components/ui/badge";
-import { Plus, Edit, Copy, Trash, Loader2 } from "lucide-react";
-import Link from "next/link";
-import { Workflow } from "@/types/workflow";
-import { workflowApi } from "@/lib/api/workflows";
+import { useState, useEffect } from 'react';
+import { Button } from '@/components/ui/button';
+import { Card } from '@/components/ui/card';
+import { Badge } from '@/components/ui/badge';
+import { Plus, Edit, Copy, Trash, Loader2 } from 'lucide-react';
+import Link from 'next/link';
+import { Workflow } from '@/types/workflow';
+import { workflowApi } from '@/lib/api/workflows';
 
 export default function WorkflowsPage() {
   const [workflows, setWorkflows] = useState<Workflow[]>([]);
@@ -20,7 +20,7 @@ export default function WorkflowsPage() {
         const data = await workflowApi.getWorkflows();
         setWorkflows(data);
       } catch (error) {
-        console.error("Failed to fetch workflows", error);
+        console.error('Failed to fetch workflows', error);
       } finally {
         setLoading(false);
       }
@@ -34,9 +34,7 @@ export default function WorkflowsPage() {
       <div className="flex justify-between items-center">
         <div>
           <h1 className="text-3xl font-bold">Workflow Configuration</h1>
-          <p className="text-muted-foreground mt-1">
-            Manage workflow definitions and routing rules
-          </p>
+          <p className="text-muted-foreground mt-1">Manage workflow definitions and routing rules</p>
         </div>
         <Link href="/admin/workflows/new">
           <Button>
@@ -57,24 +55,20 @@ export default function WorkflowsPage() {
               <div className="flex justify-between items-start">
                 <div className="flex-1">
                   <div className="flex items-center gap-3 mb-2">
-                    <h3 className="text-lg font-semibold">
-                      {workflow.workflowName}
-                    </h3>
-                    <Badge variant={workflow.isActive ? "default" : "secondary"} className={workflow.isActive ? "bg-green-600 hover:bg-green-700" : ""}>
-                      {workflow.isActive ? "Active" : "Inactive"}
+                    <h3 className="text-lg font-semibold">{workflow.workflowName}</h3>
+                    <Badge
+                      variant={workflow.isActive ? 'default' : 'secondary'}
+                      className={workflow.isActive ? 'bg-green-600 hover:bg-green-700' : ''}
+                    >
+                      {workflow.isActive ? 'Active' : 'Inactive'}
                     </Badge>
                     <Badge variant="outline">v{workflow.version}</Badge>
                   </div>
-                  <p className="text-sm text-muted-foreground mb-3">
-                    {workflow.description}
-                  </p>
+                  <p className="text-sm text-muted-foreground mb-3">{workflow.description}</p>
                   <div className="flex gap-6 text-sm text-muted-foreground">
                     <span>Type: {workflow.workflowType}</span>
                     <span>Steps: {workflow.stepCount}</span>
-                    <span>
-                      Updated:{" "}
-                      {new Date(workflow.updatedAt).toLocaleDateString()}
-                    </span>
+                    <span>Updated: {new Date(workflow.updatedAt).toLocaleDateString()}</span>
                   </div>
                 </div>
 
@@ -85,11 +79,16 @@ export default function WorkflowsPage() {
                       Edit
                     </Button>
                   </Link>
-                  <Button variant="outline" size="sm" onClick={() => alert("Clone functionality mocked")}>
+                  <Button variant="outline" size="sm" onClick={() => alert('Clone functionality mocked')}>
                     <Copy className="mr-2 h-4 w-4" />
                     Clone
                   </Button>
-                  <Button variant="outline" size="sm" className="text-destructive hover:text-destructive" onClick={() => alert("Delete functionality mocked")}>
+                  <Button
+                    variant="outline"
+                    size="sm"
+                    className="text-destructive hover:text-destructive"
+                    onClick={() => alert('Delete functionality mocked')}
+                  >
                     <Trash className="mr-2 h-4 w-4" />
                     Delete
                   </Button>